Repository navigation
fix: drop maxShutdownDelaySeconds from Render Blueprint - #51
Merged
Merged
Conversation
Render rejects maxShutdownDelaySeconds for services with a persistent disk. The omitted setting defaults to a 30-second graceful shutdown delay, so behavior is unchanged; Uvicorn still drains for up to 20 seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render's Blueprint validation rejects
render.yamlwith:Change
maxShutdownDelaySeconds: 30from theflipper-appservice. Render's default graceful shutdown delay is 30 seconds when omitted, so shutdown behavior is unchanged.Start command, Uvicorn
--timeout-graceful-shutdown 20, disk, plan, region, instances, health check, env vars, and secrets are untouched. No tests referenced the field.Verification
pytest tests/test_deployment.py: 12 passed, 1 skippedpytest: 802 passed, 4 skippedruff check ./ruff format --check .: cleanmkdocs build --strict: cleangit diff --check: cleanNothing deployed; no Render resources or databases touched.