Repository navigation
Stabilize json_feed_collector formatting to unblock CI test (pull_request) job - #53
Merged
Merged
Conversation
Co-authored-by: quangshuynh <3589146+quangshuynh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job CI / test (pull_request)
Stabilize Oct 3, 2026
json_feed_collector formatting to unblock CI test (pull_request) job
quangshuynh
marked this pull request as ready for review
October 3, 2026 00:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CI / test (pull_request)workflow was failing inruff format --check .due tocollectors/json_feed_collector.pybeing flagged for reformat. This PR applies a minimal code-only adjustment to make the formatter output stable without changing collector behavior.Change made (format-stable expression layout)
location_textfallback/coercion path in_build_listingfrom a single long inline expression into a two-step assignment.location_textstill resolves fromlocation_text→location→city→ empty string, then coerces tostr).Why this addresses the CI failure