Skip to content

Stabilize json_feed_collector formatting to unblock CI test (pull_request) job - #53

Merged
quangshuynh merged 3 commits into
mainfrom
copilot/fix-ci-test-pull-request
Oct 3, 2026
Merged

quangshuynh merged 3 commits into
mainfrom
copilot/fix-ci-test-pull-request

Conversation

Copilot AI commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

The CI / test (pull_request) workflow was failing in ruff format --check . due to collectors/json_feed_collector.py being flagged for reformat. This PR applies a minimal code-only adjustment to make the formatter output stable without changing collector behavior.

  • Change made (format-stable expression layout)

    • Refactored the location_text fallback/coercion path in _build_listing from a single long inline expression into a two-step assignment.
    • Preserves existing semantics (location_text still resolves from location_text → location → city → empty string, then coerces to str).
  • Why this addresses the CI failure

    • Removes the formatter-sensitive long inline expression that CI identified as needing reformat in this file.
location_text_raw = item.get("location_text") or item.get("location") or item.get("city")
location_text = str(location_text_raw or "")

Co-authored-by: quangshuynh <3589146+quangshuynh@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job CI / test (pull_request) Stabilize json_feed_collector formatting to unblock CI test (pull_request) job Oct 3, 2026
Copilot AI requested a review from quangshuynh October 3, 2026 00:05
@quangshuynh
quangshuynh marked this pull request as ready for review October 3, 2026 00:08
@quangshuynh
quangshuynh merged commit 8132299 into main Oct 3, 2026
2 of 3 checks passed
@quangshuynh
quangshuynh deleted the copilot/fix-ci-test-pull-request branch October 3, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants