Use pytest features to avoid having to use mv#1022
Merged
mhucka merged 1 commit intoquantumlib:mainfrom Feb 27, 2026
Merged
Conversation
This updates the `test-command` parameter for cibuildwheel to include the argument `--import-mode=importlib` to pytest. This argument directs pytest not to add the project root to `sys.path` in a way that would cause the local `qsimcirq` source directory to shadow the installed wheel. This makes the manual moving of the directory unnecessary.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request successfully refactors the test command in pyproject.toml by leveraging pytest's --import-mode=importlib feature. This change eliminates the need for the mv workaround, making the testing process more robust and the configuration cleaner. The addition of a comment explaining the new pytest argument is also a good practice, enhancing maintainability.
pavoljuhas
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
test-commandparameter for cibuildwheel to include the argument--import-mode=importlibto pytest. This argument directs pytest not to add the project root tosys.pathin a way that would cause the localqsimcirqsource directory to shadow the installed wheel. This makes the manual moving of the directory unnecessary.