Add modern .NET targets and remove C5 - #8
Open
cwithfourplus wants to merge 1 commit into
Open
cwithfourplus wants to merge 1 commit into
cwithfourplus wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
TDigestfor .NET Framework 4.5 and 4.7.2, .NET Standard 2.0, .NET 8, and .NET 10 while preserving the existing public API and strong-name identity.SortedSetimplementation that materializes nearest-centroid candidates before mutation and keeps updates logarithmic.masterusing theNUGET_API_KEYrepository secret.Why
C5 2.3.0.1 only targets .NET Framework and its live collection enumeration can throw when centroid updates mutate the digest. Removing it enables modern target frameworks and prevents collection-modified failures without changing the library's exported contract.
How it was validated
TDigest.2.0.0.nupkgwithnet45,net472,netstandard2.0,net8.0, andnet10.0assemblies and no C5 dependency groups.net45API against the published TDigest 1.0.7 package; type, constructor, method, and property signatures match exactly.