Fix bug where visual editor removes the first nested checkbox#895
Merged
Fix bug where visual editor removes the first nested checkbox#895
Conversation
vezwork
force-pushed
the
fix/visual-editor-removes-first-nested-checkbox
branch
from
ce1a674 to
6a29de0
Compare
vezwork
commented
Jan 22, 2026
| }); | ||
| } | ||
|
|
||
| // return |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #894
Adds a roundtrip test that passes in this branch but fails on main.
Cause description
tokensWithCheckedfunction calledmapTokensto detect and modify checkbox nodes in the AST.mapTokensacts recursively on the entire sub-AST passed in, so it would modify AST nodes of nested lists, removing their checkboxes.The bug was extra confusing to diagnose because 1. also meant that
tokensWithCheckedmodifies the original AST. I was logging the AST before the call totokensWithCheckedto try to understand the issue, but realized after that the logged AST was being modified after being logged, so I was seeing the modified version.That's gross. So, in this PR I've also made it so
tokensWithCheckeddoes not modify the original AST, it instead returns a modified sub-AST.