Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 652b9ea094
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ]) | ||
| .to_matchable()]) | ||
| .config(|this| { | ||
| this.terminators = vec![Ref::keyword("END").to_matchable()]; |
There was a problem hiding this comment.
ProcedureStatements runs in greedy mode but stops on a bare END, which causes BEGIN ... END blocks to terminate at the first inner END token and breaks nested control-flow blocks such as IF ... END IF inside a procedure body. In practice, a block like BEGIN IF (...) THEN ... END IF; END; now produces unparsable sections at IF/END IF because the outer body is trimmed before the inner statement can match; the terminator needs to distinguish the outer END from END IF/WHILE/LOOP/REPEAT (or otherwise avoid a single-token END cutoff).
Useful? React with 👍 / 👎.
Benchmark for 02f0ca5Click to view benchmark
|
1 participant
No description provided.