Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 101 additions & 0 deletions crates/lib/src/rules/aliasing/al05.rs
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,10 @@ FROM foo
continue;
}

if self.has_function_alias_reference(alias, &select_info, context.dialect.name) {
continue;
}

if alias.aliased
&& !payload
.tbl_refs
Expand Down Expand Up @@ -395,6 +399,43 @@ impl RuleAL05 {
false
}

fn has_function_alias_reference(
&self,
alias: &AliasInfo,
select_info: &SelectStatementColumnsAndTables,
dialect_name: DialectKind,
) -> bool {
let Some(table_expression) = alias
.from_expression_element
.child(const { &SyntaxSet::single(SyntaxKind::TableExpression) })
else {
return false;
};

if table_expression
.child(const { &SyntaxSet::single(SyntaxKind::Function) })
.is_none()
{
return false;
}

let alias_name = self.alias_name(alias, dialect_name);

select_info.reference_buffer.iter().any(|reference| {
let references = reference.iter_raw_references();
if references.len() != 1 {
return false;
}

references
.first()
.and_then(|reference_part| reference_part.segments.first())
.is_some_and(|segment| {
self.normalize_identifier(segment, dialect_name) == alias_name
})
})
}

fn report_unused_alias(&self, alias: &AliasInfo) -> LintResult {
let mut fixes = vec![LintFix::delete(alias.alias_expression.clone().unwrap())];

Expand Down Expand Up @@ -527,3 +568,63 @@ impl RuleAL05 {
false
}
}

#[cfg(test)]
mod tests {
use crate::core::config::FluffConfig;
use crate::core::linter::core::Linter;

const POSTGRES_JSON_ALIAS_REPRODUCER: &str = r#"with stanza as (
select
data -> 'name' as name,
data -> 'backup' -> (
jsonb_array_length(data -> 'backup') - 1
) as last_backup,
data -> 'archive' -> (
jsonb_array_length(data -> 'archive') - 1
) as current_archive
from jsonb_array_elements(monitor.pgbackrest_info()) as data
)

select
name,
to_timestamp(
(last_backup -> 'timestamp' ->> 'stop')::numeric
) as last_successful_backup,
current_archive ->> 'max' as last_archived_wal
from stanza;
"#;

fn postgres_al05_linter() -> Linter {
let config = FluffConfig::from_source(
r#"
[sqruff]
rules = AL05
dialect = postgres
"#,
None,
);

Linter::new(config, None, None, true).unwrap()
}

#[test]
fn test_al05_postgres_json_operator_alias_is_used() {
let mut linter = postgres_al05_linter();
let linted = linter
.lint_string_wrapped(POSTGRES_JSON_ALIAS_REPRODUCER, false)
.unwrap();

assert_eq!(linted.violations(), &[]);
}

#[test]
fn test_al05_postgres_json_operator_fix_preserves_alias() {
let mut linter = postgres_al05_linter();
let linted = linter
.lint_string_wrapped(POSTGRES_JSON_ALIAS_REPRODUCER, true)
.unwrap();

assert_eq!(linted.fix_string(), POSTGRES_JSON_ALIAS_REPRODUCER);
}
}
44 changes: 44 additions & 0 deletions crates/lib/test/fixtures/rules/std_rule_cases/AL05.yml
Original file line number Diff line number Diff line change
Expand Up @@ -530,3 +530,47 @@ test_fail_redshift_qualify_does_not_follows_from:
configs:
core:
dialect: redshift

test_pass_postgres_json_arrow_operator_alias_reference:
# sqruff issue #2327
pass_str: |
SELECT data -> 'name' AS name
FROM jsonb_array_elements('[{"name": "backup"}]'::jsonb) AS data;
configs:
core:
dialect: postgres

test_pass_postgres_json_arrow_text_operator_alias_reference:
# sqruff issue #2327
pass_str: |
SELECT data ->> 'name' AS name
FROM jsonb_array_elements('[{"name": "backup"}]'::jsonb) AS data;
configs:
core:
dialect: postgres

test_pass_postgres_json_arrow_operator_alias_reference_reproducer:
# sqruff issue #2327
pass_str: |
with stanza as (
select
data -> 'name' as name,
data -> 'backup' -> (
jsonb_array_length(data -> 'backup') - 1
) as last_backup,
data -> 'archive' -> (
jsonb_array_length(data -> 'archive') - 1
) as current_archive
from jsonb_array_elements(monitor.pgbackrest_info()) as data
)

select
name,
to_timestamp(
(last_backup -> 'timestamp' ->> 'stop')::numeric
) as last_successful_backup,
current_archive ->> 'max' as last_archived_wal
from stanza;
configs:
core:
dialect: postgres
Loading