Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/contracts.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ In order to develop a contract, follow these steps:
## Review and tests

Each contract must be validated with the following steps:
1. The contract is verified with the [Qubic Contract Verification Tool](https://github.com/Franziska-Mueller/qubic-contract-verify), ensuring that it complies with the formal requirements mentioned above, such as no use of [forbidden C++ features](#restrictions-of-c-language-features).
1. The contract is verified with the [Qubic Contract Verification Tool](https://github.com/qubic/contract-verify), ensuring that it complies with the formal requirements mentioned above, such as no use of [forbidden C++ features](#restrictions-of-c-language-features).
In the `qubic/core` repository, the tool is run automatically as GitHub workflow for PRs to the `develop` and `main` branches (as well as for commits in these branches).
However, since workflow runs on PRs require maintainer approval, we highly recommend to either build the tool from source or use the GitHub action provided in the tool's repository to analyze your contract header file before opening your PR.
2. The features of the contract have to be extensively tested with automated tests implemented within the Qubic Core's GoogleTest framework.
Expand Down
2 changes: 1 addition & 1 deletion doc/contracts_oracles.md
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ static sint64 getSubscriptionFee(const OracleQuery& query, uint32 notifyPeriodIn
Additionally, the interface struct may contain other structs or convenience features for contracts using the oracle interface.

All code in the interface header file must respect the same [C++ language feature restrictions as contracts](#restrictions-of-c-language-features) (except for a few differences listed below).
These are checked with the [Qubic Contract Verification Tool](https://github.com/Franziska-Mueller/qubic-contract-verify).
These are checked with the [Qubic Contract Verification Tool](https://github.com/qubic/contract-verify).

The C++ language feature restrictions of oracle interfaces differ in the following points from those of contracts:

Expand Down
1 change: 0 additions & 1 deletion src/Qubic.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
<ClInclude Include="contracts\QBAY.h" />
<ClInclude Include="contracts\Nostromo.h" />
<ClInclude Include="contracts\QRaffle.h" />
<ClInclude Include="contracts\QRaffle_old.h" />
<ClInclude Include="contracts\QBond.h" />
<ClInclude Include="contracts\QIP.h" />
<ClInclude Include="contracts\Qusino.h" />
Expand Down
3 changes: 0 additions & 3 deletions src/Qubic.vcxproj.filters
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,6 @@
<ClInclude Include="contracts\QRaffle.h">
<Filter>contracts</Filter>
</ClInclude>
<ClInclude Include="contracts\QRaffle_old.h">
<Filter>contracts</Filter>
</ClInclude>
<ClInclude Include="contracts\QBond.h">
<Filter>contracts</Filter>
</ClInclude>
Expand Down
4 changes: 0 additions & 4 deletions src/contract_core/contract_def.h
Original file line number Diff line number Diff line change
Expand Up @@ -209,11 +209,7 @@
#define CONTRACT_INDEX QRAFFLE_CONTRACT_INDEX
#define CONTRACT_STATE_TYPE QRAFFLE
#define CONTRACT_STATE2_TYPE QRAFFLE2
#ifdef OLD_QRAFFLE
#include "contracts/QRaffle_old.h"
#else
#include "contracts/QRaffle.h"
#endif

#undef CONTRACT_INDEX
#undef CONTRACT_STATE_TYPE
Expand Down
Loading
Loading