unexpected 'await' keyword on function declaration

[HicaroD]

#413

[strager]

You should follow the syntactic style of existing diagnostics (like E0178) instead:

Suggested change

	[[qljs::message("Unexpected 'await' keyword on function declaration. Maybe you meant 'async'?",
	ARG(await_keyword))]] //
	[[qljs::message("unexpected 'await' keyword on function declaration; maybe you meant 'async'?",
	ARG(await_keyword))]] //

[strager]

Nit: Undo.

[strager]

Must fix: Your special handling of function is wrong in a few ways:

• await function foo() {}(); is parsed incorrectly. You have a test for it, but test_parse_and_visit_statement doesn't assert that the whole input is parsed. (It probably should... I should fix that.) This code is parsing await function foo() {} as a statement, leaving (); as a second statement (which is wrong!).
• await function () {} falsely reports E0061 ("missing name in function statement").

Also, adding code here in parse_and_visit_expression doesn't catch mistakes such as the following:

foo(await function() {
});

parse_await_expression is probably a better place to put your logic.