Allow hex strings without 0x prefix - #104
Open
zemse wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The "0x" prefix solves the ambiguity for the string "11", which could represent eleven or seventeen. Hence, it makes sense to include "0x" prefix everywhere in general.
However, a lot of popular tools in the ecosystem omit "0x" prefix. E.g. Bytecode from Remix, Hardhat, Solc compiler, evm.codes playground. And this does not create any ambiguity at all, since bytecode is supposed to be in hex format. Etk cli does not accept bytecode in a different format. Hence, flexibility can be provided to accept a hex string with or without "0x" prefix, for improving the convenience of the dev/user.
A related case: ethers.js is quiet strict with requirement of "0x" prefix, but the requirement of the prefix for private keys was made optional, because a lot of common tools do not prefix private keys with a 0x ethers-io/ethers.js@29f6c34
Before:
After