feat: negative to unsigned int conversion - #119
Open
bsh98 wants to merge 2 commits into
Open
Conversation
bsh98
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #79
Approach
Added
uintN(), a built-in expression macro to convert negative evaluating expressions to positive values. A new expression typeUintwas added to account for the case when the expression needs to be evaluated with context (e.g. user-defined macro). Any feedback is greatly appreciated!Example
push1 uint8(-1)evaluates to0x60ff.Alternatives
It may be a bit cleaner to just add built-in macros for max unsigned integer values (e.g.
max_uint256()). I could also see some benefit to implementing bitwise operators (e.g.1 << 256). However, the current approach also allows for representing negative integers in two's-compliment, which could be of value.todo
Will update docs if changes are deemed appropriate.