Proposal: Hardfork selection via flag - #135
Open
gzanitti wants to merge 75 commits into
Open
Conversation
… "push label" ops
… remains correct over time.
…is messy and there are several hacks I need to remove. Also I should write a more rusty code.
…the code should be optimized, but the general idea seems to work.
…ressing some of the changes proposed by Sam.
gzanitti
marked this pull request as ready for review
January 29, 2024 17:29
Contributor
Author
|
Hey @SamWilsn, I'm moving forward with the changes we had pending now that the new backend was finally merged. I hope you don't mind having to keep reviewing my code haha. This modification includes the changes we were discussing.
Whenever the range is invalid, or the flag does not match any macro definition, compilation stops. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to utilize the operations specific to each hardfork in ETK.
By employing a flag (e.g., --hardfork cancun), users can designate the hardfork to be used during the parsing and assembly processes. A primary benefit of this enhancement is its streamlined approach to managing compatibility across various EVM versions. This update allows for more straightforward handling of operation deprecation and aliasing.
The core alteration involves encapsulating the operations specific to each Hardfork within an enum responsible for managing different versions.
This revision builds upon PR #133 . However, it can be modified if PR 133 is not approved. Still in draft while I tidy up the code and review and adapt the code beyond the assembler.
I appreciate your insights and feedback.