Skip to content

Harden media verification, recovery, and watch-mode safety - #1

Closed
quinnuk wants to merge 12 commits into
mainfrom
agent/safety-verification-hardening
Closed

quinnuk wants to merge 12 commits into
mainfrom
agent/safety-verification-hardening

Conversation

@quinnuk

@quinnuk quinnuk commented Aug 10, 2026

Copy link
Copy Markdown
Owner

What changed

  • Reuse the full output verification logic both before replacement and after replacement.
  • Verify retained audio tracks as complete per-track signatures instead of independent property sets.
  • Verify subtitle properties and video track properties as well as counts.
  • Preserve an existing Maximum Safety Mode backup instead of overwriting it.
  • Restore from backup with a copy so persistent backups remain available after rollback.
  • Retry dependency discovery after a cached negative find_tool() result.
  • Make watch mode retry transient processing errors instead of permanently marking them processed.
  • Track processed-file identity using size/mtime so replacement files at the same path are reconsidered.
  • Add regression tests for exact track verification, Maximum Safety Mode recovery, and watcher behaviour.

Why

These changes close the remaining safety gaps identified during code review, particularly around post-replacement verification and false-positive track validation.

Validation

GitHub Actions will run the repository's existing test and build workflows for this pull request.

@quinnuk quinnuk closed this Aug 10, 2026
@quinnuk
quinnuk deleted the agent/safety-verification-hardening branch August 10, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant