Open
Conversation
|
I'm 👍 for this, having found this pull-request made my day! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi James,
I made some changes to the p4ruby installer, so that it works now with a windows ruby 1.9.3 version. The windows installer provided by Perforce only support ruby 1.8.
If the Windows Ruby Devkit and additionally zip and tar are installed on a system, the normal installation with building the native extension works now. I noted some comments on a project wiki page.
So it would be nice if you could review the changes and pull them into your master. I guess this is needed, if I want to install it via gem. (Probably I missed to changed some version numbers.)
Thanks and Best Regards,