Use CUDACore and cuSPARSE as dependencies instead of CUDA#687
Conversation
12cb5de to
1f8b2df
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
+ Coverage 92.25% 93.22% +0.97%
==========================================
Files 57 57
Lines 3914 3914
==========================================
+ Hits 3611 3649 +38
+ Misses 303 265 -38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
CUDA 6 is not used here yet. Let's wait |
|
Currently waiting this PR to be merged in |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Benchmark Results'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: c3e21a1 | Previous: 95e0442 | Ratio |
|---|---|---|---|
Autodiff/mesolve/Forward |
209771293.5 ns |
156255678 ns |
1.34 |
Autodiff/sesolve/Forward |
41175610.5 ns |
25690275 ns |
1.60 |
This comment was automatically generated by workflow using github-action-benchmark.
|
It seems that they moved to another PR: exanauts/CUDSS.jl#144 |
CUDACore and cuSPARSE as dependencies instead of CUDA
|
We are currently waiting this PR SciML/LinearSolve.jl#983 to be merged. The After the issue in |
|
Thanks to this PR SciML/LinearSolve.jl#986 we should be ready, right? |
albertomercurio
left a comment
There was a problem hiding this comment.
LGTM. Just a minor comment.
This pull request changes the compat entry for the
CUDApackage from5.9.6to5.9.6, 6.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.