Skip to content

Use CUDACore and cuSPARSE as dependencies instead of CUDA#687

Merged
ytdHuang merged 11 commits into
mainfrom
compathelper/new_version/2026-04-11-01-48-21-552-01756831860
May 19, 2026
Merged

Use CUDACore and cuSPARSE as dependencies instead of CUDA#687
ytdHuang merged 11 commits into
mainfrom
compathelper/new_version/2026-04-11-01-48-21-552-01756831860

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This pull request changes the compat entry for the CUDA package from 5.9.6 to 5.9.6, 6.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@albertomercurio albertomercurio force-pushed the compathelper/new_version/2026-04-11-01-48-21-552-01756831860 branch from 12cb5de to 1f8b2df Compare April 11, 2026 01:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.22%. Comparing base (e970d34) to head (29d6450).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
+ Coverage   92.25%   93.22%   +0.97%     
==========================================
  Files          57       57              
  Lines        3914     3914              
==========================================
+ Hits         3611     3649      +38     
+ Misses        303      265      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@albertomercurio
Copy link
Copy Markdown
Member

CUDA 6 is not used here yet. Let's wait

@ytdHuang
Copy link
Copy Markdown
Member

ytdHuang commented May 1, 2026

Currently waiting this PR to be merged in CUDSS: exanauts/CUDSS.jl#141

Copy link
Copy Markdown
Contributor Author

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Benchmark Results'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: c3e21a1 Previous: 95e0442 Ratio
Autodiff/mesolve/Forward 209771293.5 ns 156255678 ns 1.34
Autodiff/sesolve/Forward 41175610.5 ns 25690275 ns 1.60

This comment was automatically generated by workflow using github-action-benchmark.

@ytdHuang
Copy link
Copy Markdown
Member

It seems that they moved to another PR: exanauts/CUDSS.jl#144

@ytdHuang ytdHuang changed the title CompatHelper: bump compat for CUDA in [weakdeps] to 6, (keep existing compat) Use CUDACore and cuSPARSE as dependencies instead of CUDA May 13, 2026
@ytdHuang
Copy link
Copy Markdown
Member

We are currently waiting this PR SciML/LinearSolve.jl#983 to be merged.

The eigen GPU test breaks because the CUDSS is not loaded correctly.

After the issue in LinearSolveCUDSSExt is solved, I think the test will pass.

@albertomercurio
Copy link
Copy Markdown
Member

Thanks to this PR SciML/LinearSolve.jl#986 we should be ready, right?

Copy link
Copy Markdown
Member

@albertomercurio albertomercurio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor comment.

Comment thread docs/src/users_guide/extensions/cuda.md Outdated
Comment thread docs/src/users_guide/extensions/cuda.md Outdated
@ytdHuang ytdHuang merged commit 3d013a7 into main May 19, 2026
@ytdHuang ytdHuang deleted the compathelper/new_version/2026-04-11-01-48-21-552-01756831860 branch May 19, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants