Skip to content

Add guildId to rssFeeds collection schema#230

Open
eritbh wants to merge 7 commits intomainfrom
add-guild-to-rss-feeds
Open

Add guildId to rssFeeds collection schema#230
eritbh wants to merge 7 commits intomainfrom
add-guild-to-rss-feeds

Conversation

@eritbh
Copy link
Copy Markdown
Member

@eritbh eritbh commented Aug 17, 2022

Stores the guild where RSS feeds were created and filters by that guild (or, in DMs, the ID of the channel) when listing and deleting feeds. This fixes a bug where feeds would be exposed across servers, which we never encountered because nobody else uses this bot.

This will require manual migration of existing feeds after merging - for each existing feed, fetch the feed's channel and put its guild ID back into the object.

@eritbh eritbh added the bug Something isn't working label Aug 17, 2022
@eritbh eritbh requested a review from a team as a code owner August 17, 2022 02:49
Copy link
Copy Markdown
Contributor

@mushroom-disaster mushroom-disaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems different spellings have been used for guild ID in the migration and commands. guildID in the migration and guildId in the commands which causes them to fail

@eritbh
Copy link
Copy Markdown
Member Author

eritbh commented Oct 28, 2022

Review should be addressed now, don't mind me taking 2 months to change three lines

@eritbh eritbh requested review from a team and mushroom-disaster October 28, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants