Open
Conversation
lionel-
reviewed
Feb 17, 2026
src/base64.c
Outdated
| if (j + 1 < outlen) { | ||
| SEXP rout2 = PROTECT(allocVector(RAWSXP, j)); | ||
| memcpy(RAW(rout2), RAW(rout), j); | ||
| if (j) memcpy(RAW(rout2), RAW_RO(rout), j); |
There was a problem hiding this comment.
Maybe wrap this in r_memcpy as in vctrs? There would be much less chance of reintroducing the pattern while changing code.
Contributor
Author
There was a problem hiding this comment.
SGTM. although there's a different backsliding risk introduced (enforcing r_memcpy over memcpy), I think the tradeoff still favors reusing the rlang routine.
Contributor
Author
There was a problem hiding this comment.
What's your preference for how to include it? LinkingTo: rlang and #include <rlang.h>?
MichaelChirico
commented
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in r-lib/vctrs#1968.