Fix length() equality precedence in input validation - #906
Closed
sims1253 wants to merge 1 commit into
Closed
Conversation
In pkg_deps_explain(), pkg_status(), and pkg_deps_tree() the input validation guard was written as length(pkg == 1) instead of length(pkg) == 1. Because the equality test sat inside length(), the expression evaluated to length(<logical>) and never actually checked that pkg is length 1. Move the closing paren so the comparison is outside length().
Member
|
Duplicate of #902? |
Author
|
Seems so, sorry for not checking open PRs before filing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In pkg_deps_explain(), pkg_status(), and pkg_deps_tree() the input validation guard was written as length(pkg == 1) instead of length(pkg) == 1. Because the equality test sat inside length(), the expression evaluated to length() and never actually checked that pkg is length 1. Move the closing paren so the comparison is outside length().
Found with ry