fix: clearer error when wrt arg is a plain R literal#308
Merged
Conversation
When a `wrt` argument is passed as a plain R numeric (e.g. `gradient(nv_log, wrt = "operand")(1)`), it is inlined as a constant during tracing rather than registered as a graph input. The gradient transform then produced zero outputs while `out_tree` still expected one leaf, surfacing as a cryptic `subscript out of bounds` from `unflatten.LeafNode`. Detect this in `compute_requirements()` and abort with a message naming the offending argument(s) and pointing to `nv_array()`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODOs: