feat: add ComplexType to the DataType hierarchy#5
Open
sebffischer wants to merge 1 commit into
Open
Conversation
Adds ComplexType(value) for representing complex<f32> (c64) and complex<f64> (c128) tensor element types, mirroring the structure of FloatType. Extends as_dtype() and dtype_map to recognize "c64" and "c128" strings. Needed by stablehlo for the upcoming hlo_fft() op. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComplexType(value)forcomplex<f32>/complex<f64>(a.k.a.c64/c128), mirroringFloatType.as_dtype()anddtype_mapto recognize"c64"and"c128"strings.DataTypevirtual-class docs and theassert_dtypeerror message to mentionComplexType.Prerequisite for
hlo_fft()in stablehlo (which uses complex element types per the StableHLO spec).Test plan
testthat::test_local("tengen")— 40 passed, 0 failures.ComplexType(32)prints as<c64>,ComplexType(64)as<c128>.as_dtype("c64")andas_dtype("c128")round-trip.🤖 Generated with Claude Code