Repository navigation
Let the next call prompt after a recorded call ends - #2281
Open
jdustinlewis wants to merge 1 commit into
Open
jdustinlewis wants to merge 1 commit into
jdustinlewis wants to merge 1 commit into
Conversation
Record on a detected call quieted that provider for 30 minutes (or until the matching calendar event ended), and the quiet outlived the call. So the next call of the same kind, often a back-to-back meeting, never got a prompt. Seen live: a recorded Meet call, then three more Meet calls in the next 7 minutes, none prompted. When the detected-call session ends with the recording stopped, cut Record's quiet to 60 s and re-check then: a mic flap at hang-up stays quiet, the next call prompts. A session that ends while still recording may be a mute (Safari lets go of the mic), so the quiet holds until a session ends, or a new one starts, with the recording stopped. A recorded calendar event keeps its own snooze. Review: independent Claude review found that cutting on any session end let a mid-call mute re-prompt the recorded call after Stop; fixed here and covered by tests.
13 of 19 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2280.
Why
When you hit Record on a detected call,
markAcceptedmutes prompts for that provider until the matching calendar event ends (+5 min). With no event, the mute lasts 30 min. The mute stayed on after the call ended, so the next call of the same kind never prompted. Back-to-back meetings hit this most. Seen live: one recorded Meet call, then three more Meet calls over the next 7 minutes, and none of them prompted.Product Impact
meetingsmeeting reliabilityWhat changed
recordedCallEndGrace(60 s), with one re-check scheduled at that point. A mic flap at hang-up stays quiet, and the next call prompts.stop()now cancels the re-check.Sources/Meeting/AGENTS.mddescribes the rule.How I checked it
scripts/dev/agent-preflight.shbash scripts/dev/linux-checks.sh(runs without Swift).agents/test-matrix.ymlfor the files changed (bash check.sh: deterministic proof PASS, 50,077 tests passed)bash build.sh --no-openbash run-tests.sh --filter MeetingPromptDetector: 147/147. Four new tests:bash run-integration-smoke.shif I touchedSources/Meeting/orSources/TranscriptedCore/swift testif I touchedPackage.swift,Sources/TranscriptedCore/, or the public core seambash run-e2e-smoke.sh/swift test --package-path Tools/<Package>if the matrix maps themChecks I could not run, and why:
run-integration-smoke.shandbuild.shweren't run on their own;check.shpicked what to run for this diff.Mac or hardware test still needed? Yes:
main: no prompt for 30 min.main: no prompt.mainalso stays quiet here; this checks the fix didn't break it.)Risk Review
check-source-pins.py --changed-only: pass)Notes
🤖 Generated with Claude Code