fix(e2e): type the getContext override so next build passes - #293
Merged
Conversation
|
@sktbrd is attempting to deploy a commit to the r4to's projects Team on Vercel. A member of the Team first needs to authorize it. |
The webgl-fallback spec's interceptor assigned a generic function over the DOM lib's per-id getContext overloads — tsc (and therefore next build) rejected it, which would have failed the production deploy of the very PR it guards. Assign through the original's own type; runtime passthrough unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sktbrd
force-pushed
the
fix/webgl-spec-types
branch
from
August 23, 2026 14:55
c551e71 to
95908c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge gate on #282 caught this: the webgl-fallback spec's
getContextinterceptor failstsc --noEmit(generic function vs the DOM lib's per-id overloads) — and sincenext buildtype-checks, the production deploy of the merged batch would fail. One-file typing fix; runtime behavior identical.Test plan
tsc --noEmitclean on merged main + this fixGenerated with Claude Code