Skip to content

fix(dashboard): guard EditAgentDrawer save and rename against double submit #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ra-co88 merged 1 commit into from
Oct 12, 2026
Merged

fix(dashboard): guard EditAgentDrawer save and rename against double submit #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion dashboard/src/pages/Experts/components/EditAgentDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,10 @@ function EditAgentDrawerBody({
const [loading, setLoading] = useState(false);
const [filesLoading, setFilesLoading] = useState(false);
const [saving, setSaving] = useState(false);
// Synchronous in-flight latch: `saving` only flips after a re-render, and
// performSave awaits validation and the root-dir probe before
// setSaving(true), so a second click in that window would start a second save.
const savingRef = useRef(false);
const [fileModalOpen, setFileModalOpen] = useState(false);
const [editingFile, setEditingFile] = useState<string | null>(null);
const [listRenameOpen, setListRenameOpen] = useState(false);
Expand All @@ -259,6 +263,7 @@ function EditAgentDrawerBody({
"config",
);
const [listRenameSaving, setListRenameSaving] = useState(false);
const listRenameSavingRef = useRef(false);
const [subagentCatalogOpen, setSubagentCatalogOpen] = useState(false);
const [skillCatalogOpen, setSkillCatalogOpen] = useState(false);
const welcomeConfigRef = useRef<WelcomeConfigRef>(null);
Expand Down Expand Up @@ -391,7 +396,7 @@ function EditAgentDrawerBody({
};
}, [agent.agent_id, agent.state, form, message, t]);

const handleSave = useCallback(async () => {
const performSave = useCallback(async () => {
const values = await form.validateFields();
if (values.backend_choice === "composite") {
const pathError = validatePathMappings(pathMappings, t);
Expand Down Expand Up @@ -540,6 +545,16 @@ function EditAgentDrawerBody({
t,
]);

const handleSave = useCallback(async () => {
if (savingRef.current) return;
savingRef.current = true;
try {
await performSave();
} finally {
savingRef.current = false;
}
}, [performSave]);

useEffect(() => {
onSaveReady(handleSave);
}, [handleSave, onSaveReady]);
Expand Down Expand Up @@ -657,6 +672,7 @@ function EditAgentDrawerBody({
};

const confirmListRename = async () => {
if (listRenameSavingRef.current) return;
if (!listRenamePath || !listRenameValue.trim()) return;
const dest = joinWorkspacePath(
parentWorkspacePath(listRenamePath),
Expand All @@ -666,6 +682,7 @@ function EditAgentDrawerBody({
setListRenameOpen(false);
return;
}
listRenameSavingRef.current = true;
setListRenameSaving(true);
try {
await workspaceApi.moveWorkspaceFile(
Expand All @@ -686,6 +703,7 @@ function EditAgentDrawerBody({
} catch (err: unknown) {
message.error(apiErrorMessage(err, t("workspace.renameFailed"), t));
} finally {
listRenameSavingRef.current = false;
setListRenameSaving(false);
}
};
Expand Down Expand Up @@ -1341,6 +1359,7 @@ function EditAgentDrawerBody({
>
<Input
value={listRenameValue}
disabled={listRenameSaving}
onChange={(e) => setListRenameValue(e.target.value)}
onPressEnter={() => void confirmListRename()}
autoFocus
Expand Down
Loading