Skip to content

Infinite Scrolling - #301

Open
SaraVieira wants to merge 9 commits into
mainfrom
feat/infinte-scrolling
Open

Infinite Scrolling#301
SaraVieira wants to merge 9 commits into
mainfrom
feat/infinte-scrolling

Conversation

@SaraVieira

@SaraVieira SaraVieira commented May 26, 2021

Copy link
Copy Markdown
Collaborator

I can still see some issues with the library, it's super laggy and I feel like it makes the experience waaay jankier.

closes #206

@SaraVieira
SaraVieira requested a review from raae May 26, 2021 21:28
},
},
root: { paddingRight: "0" },
page: { maxWidth: "100% !important" },

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hate myself

@raae

raae commented May 27, 2021

Copy link
Copy Markdown
Owner

I can still see some issues with the library, it's super laggy and I feel like it makes the experience waaay jankier.

Maybe I just need to give up on this infinite scroll thing.... create totally different ui...

@raae

raae commented May 27, 2021

Copy link
Copy Markdown
Owner

I can still see some issues with the library, it's super laggy and I feel like it makes the experience waaay jankier.

Maybe I just need to give up on this infinite scroll thing.... create totally different ui...

It feels okey on my phone, so let's go ahead.

@raae

raae commented May 29, 2021

Copy link
Copy Markdown
Owner

Do you have time to complete this before June 1st @SaraVieira?

@SaraVieira

Copy link
Copy Markdown
Collaborator Author

I don't think so since a vaccine appointment on Monday but will try tomorrow

@SaraVieira

Copy link
Copy Markdown
Collaborator Author

Let's talk Monday morning if you want

@SaraVieira

SaraVieira commented Jun 1, 2021

Copy link
Copy Markdown
Collaborator Author

Bugs

  • Click on today does nothing - Change URL to date like in calendar

  • Missing margins

CleanShot 2021-06-01 at 12 08 01@2x

  • [Header slightly smaller than rest

CleanShot 2021-06-01 at 12 07 51@2x

@SaraVieira
SaraVieira marked this pull request as ready for review June 1, 2021 18:06
@SaraVieira

Copy link
Copy Markdown
Collaborator Author

All small issues we talked about today are fixed, let me know what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Infinite Timeline scroll

2 participants