Accommodate for multiple lines in readlines#126
Open
poffey21 wants to merge 2 commits into
Open
Conversation
Accommodate for readlines returning a list of lines
Update configsnap
|
Before Tim made this fix, I was getting a lot of errors like the below. They could be experienced on modified or unmodified files.
When I use this fixed code, these problems go away! |
|
@nrhodes91 and/or @popindavibe - would it be possible for someone to review this MR? |
Contributor
|
I can't reproduce, could you @DarwinJS provide an example I could copy/paste to reproduce? Just trying to understand what's happening, though the suggested fix works for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
readlines()method may return multiple lines which need to be stitched together to avoid stdout attempt to parse a list object rather than an expected string. This aims to permit multiple lines.