fix: handles the case where a project is actually a domain (is_domain: true)#1482
Merged
Conversation
haseebsyed12
changed the title
haseebsyed12
force-pushed
the
is_domain_true_project
branch
from
089f98d to
500359f
Compare
cardoe
reviewed
Dec 5, 2025
Contributor
cardoe
left a comment
cardoe
left a comment
There was a problem hiding this comment.
So if it's a domain being updated then we need to not do any updates. We shouldn't treat it as default:sso if the domain sso is being updated.
haseebsyed12
force-pushed
the
is_domain_true_project
branch
from
500359f to
09c4cae
Compare
haseebsyed12
force-pushed
the
is_domain_true_project
branch
from
09c4cae to
c82775e
Compare
cardoe
reviewed
Dec 8, 2025
haseebsyed12
force-pushed
the
is_domain_true_project
branch
2 times, most recently
from
fd5cc9c to
174bead
Compare
skip Nautobot sync when project is actually a domain. when syncing a domain like "sso" this error `Request requires an ID but none was found` use to occur
haseebsyed12
force-pushed
the
is_domain_true_project
branch
from
174bead to
1a20422
Compare
cardoe
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skip Nautobot sync when project is actually a domain.