feat: add storage deletion workflow with conditional execution#1492
Merged
Conversation
achatur
force-pushed
the
add_deletes_for_storage
branch
2 times, most recently
from
114b1eb to
99b71d8
Compare
achatur
force-pushed
the
add_deletes_for_storage
branch
from
7630230 to
26c6206
Compare
cardoe
force-pushed
the
add_deletes_for_storage
branch
from
5a37de0 to
9625024
Compare
achatur
force-pushed
the
add_deletes_for_storage
branch
from
9625024 to
80d9de6
Compare
cardoe
reviewed
Feb 4, 2026
| triggers the ansible playbook without requiring a Python handler. | ||
|
|
||
| The sensor extracts the following parameters from the event: | ||
| - device_id: from payload.node (the Ironic node UUID) |
Contributor
There was a problem hiding this comment.
This is the nova instance UUID and not the Ironic node which might matter here?
achatur
force-pushed
the
add_deletes_for_storage
branch
from
80d9de6 to
5ed8396
Compare
cardoe
reviewed
Feb 4, 2026
| exchangeName: nova | ||
| exchangeType: topic | ||
| exchangeDeclare: | ||
| durable: false |
Contributor
There was a problem hiding this comment.
Suggested change
| durable: false | |
| durable: true |
achatur
force-pushed
the
add_deletes_for_storage
branch
6 times, most recently
from
990b1f2 to
ed3ffc3
Compare
achatur
force-pushed
the
add_deletes_for_storage
branch
5 times, most recently
from
c71f11c to
bd1474d
Compare
achatur
force-pushed
the
add_deletes_for_storage
branch
3 times, most recently
from
d9066f4 to
4feba97
Compare
cardoe
requested changes
Feb 25, 2026
Comment on lines
+82
to
+83
| # "compute.instance.delete.end" is now handled directly by the sensor with filters | ||
| # See: components/site-workflows/sensors/sensor-nova-oslo-event.yaml |
Contributor
There was a problem hiding this comment.
You can leave these lines out.
achatur
force-pushed
the
add_deletes_for_storage
branch
from
741a02f to
6730e0d
Compare
cardoe
approved these changes
Feb 26, 2026
This change implements automated storage network cleanup triggered by OpenStack server delete events. When an instance is deleted via 'openstack server delete', the system now automatically removes the corresponding storage network configuration through an event-driven workflow. The automation flow works as follows: 1. Nova emits Oslo notification events for instance delete operations 2. Argo Events captures these notifications via RabbitMQ event source 3. Sensor filters trigger the storage cleanup workflow for delete events 4. Ansible playbooks update Nautobot to reflect the removed instance 5. Nautobot Golden Config generates updated switch configurations 6. Switch update playbook applies the network changes to remove storage network access This completes the storage network automation lifecycle (create was previously merged), enabling zero-touch storage network deprovisioning that keeps network state synchronized with compute instance lifecycle without manual intervention. Changes include: - Added Nova Oslo event source and RabbitMQ user configuration - Created sensor for Nova instance delete events with event filtering - Enabled IronicUnderstackDriver in Nova configuration for storage network integration - Updated site-workflows kustomization to include new event sources and sensors
achatur
force-pushed
the
add_deletes_for_storage
branch
from
6730e0d to
9a3225d
Compare
cardoe
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements automated storage network cleanup triggered by OpenStack server delete events. When an instance is deleted via 'openstack server delete', the system now automatically removes the corresponding storage network configuration through an event-driven workflow.
The automation flow works as follows:
This completes the storage network automation lifecycle (create was previously merged), enabling zero-touch storage network deprovisioning that keeps network state synchronized with compute instance lifecycle without manual intervention.
Changes include: