Conversation
RSabounds
changed the title
RSabounds
changed the title
stevekeay
approved these changes
Dec 18, 2025
Contributor
stevekeay
left a comment
stevekeay
left a comment
There was a problem hiding this comment.
This looks good, I left some code readability suggestions but I am happy to just merge this as it stands if you would rather keep the momentum.
stevekeay
changed the title
Stage changes for test evaluation. full-pass pre-commit interface_detail issue fix. init changes to solve challenges in use.
stevekeay
approved these changes
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating BMC code to generalize execution across hardware profiles.
As we work to generalize the enrollment process, we will eliminate multiple elements of the basic resource evaluation, and move those tasks into openstack inspection.
Basic enrollment still needs to gather base details to feed inspection however, and these are now able to perform against different HW types.
Support tested on:
Dell R740xd
Dell D7515
Dell D7615
HP DL380g9
Allows for successful gathering of basic information on all hw types, and if available, grabs LLDP info also.