feat(ironic): Adds ironic runbook for performing BMC maintenances.#2051
Open
nicholaskuechler wants to merge 1 commit into
Open
feat(ironic): Adds ironic runbook for performing BMC maintenances.#2051nicholaskuechler wants to merge 1 commit into
nicholaskuechler wants to merge 1 commit into
Conversation
nicholaskuechler
force-pushed
the
PUC-1603-20260527-1108
branch
3 times, most recently
from
e0e33d0 to
2317485
Compare
nicholaskuechler
force-pushed
the
PUC-1603-20260527-1108
branch
from
2317485 to
2632f1b
Compare
cardoe
requested changes
May 28, 2026
| redfish: | ||
| # Redfish inspection hooks run after inspecting out-of-band using the BMC: | ||
| inspection_hooks: "validate-interfaces,ports,port-bios-name,architecture,pci-devices,resource-class" | ||
| inspection_hooks: "validate-interfaces,ports,port-bios-name,architecture,pci-devices,resource-class,bmc-maintenance" |
|
|
||
| LOG = logging.getLogger(__name__) | ||
|
|
||
| BMC_MAINTENANCE_TRAIT = "CUSTOM_BMC_MAINTENANCE" |
Contributor
There was a problem hiding this comment.
No. As I've said multiple times in multiple places. Make an addition to inspection rules to do CUSTOM_$VENDOR_$MODEL and use that with runbooks v2 which lets you define many runbooks and associate them with a shared trait.
| name: bmc-maintenance | ||
| namespace: openstack | ||
| spec: | ||
| runbookName: CUSTOM_BMC_MAINTENANCE |
Contributor
There was a problem hiding this comment.
No. This is runbooks v1. We want a name and then associate the trait to it.
| port-bios-name = "ironic_understack.port_bios_name_hook:PortBiosNameHook" | ||
| node-name-check = "ironic_understack.inspect_hook_node_name_check:InspectHookNodeNameCheck" | ||
| chassis_model = "ironic_understack.inspect_hook_chassis_model:InspectHookChassisModel" | ||
| bmc-maintenance = "ironic_understack.inspect_hook_bmc_maintenance:InspectHookBmcMaintenance" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds runbook for performing BMC maintenances by clearing jobs and setting the clock.