feat(runner): allow profiling of template jobs#340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is motivated by a bug that @nKrugo13 identified in the refactored pipeline routines:
caput-pipeline template-runwill throw an error if--submitis not specified and any of theprofile,profiler,mpi_abort, orpsutilarguments are missing. This happens because_cli.template_run()calls_core.template_run(), which in turn calls_core.run_pipeline(), for which the 4 arguments above are not optional. I believe this bug was introduced in the process of decoupling the command-line interface fromrun_pipeline(): previously,run_pipeline()was called directly from the command line, and always had default values for these 4 arguments provided.In the process of fixing this bug, I realized that it would be straightforward to allow profiling of
template-runjobs, so I've implemented that here.