Add fluxcat-based point source sky map tasks#90
Merged
Conversation
Add four new classes to cora.foreground.pointsource and corresponding commands to cora-makesky for generating HEALPix sky maps from the fluxcat catalog: - FluxCatPointSources: like RealPointSources but driven by fluxcat, with optional flux_min/flux_max filtering at 600 MHz. - SingleFluxCatSource: single named source (e.g. CYG_A) looked up from fluxcat, placed in a HEALPix map at each frequency. - FluxCatCatalogMap: all sources in the loaded fluxcat catalog, no flux filtering. - CombinedFluxCatPointSources: same three-layer structure as CombinedPointSources (Gaussian unresolved + DiMatteo synthetic population + real resolved) but replaces RealPointSources with FluxCatPointSources above 4 Jy at 600 MHz. All four classes record which fluxcat collections were used in index_map/catalog in the output HDF5 file for provenance tracking. write_map gains an optional catalog_info argument to support this. New makesky commands: fluxcatpoints, singlesource-fluxcat, fluxcatcatalog, foreground-fluxcat.
Arnab-half-blood-prince
changed the title
sjforeman
approved these changes
May 13, 2026
sjforeman
left a comment
sjforeman
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just a few minor comments.
ljgray
requested changes
May 14, 2026
ljgray
left a comment
ljgray
left a comment
Contributor
There was a problem hiding this comment.
Just some minor notation/doc changes
- Rename CLI commands to follow fluxcat naming convention: fluxcatpoints -> pointsource-fluxcat fluxcatcatalog -> catalog-fluxcat - Store fluxcat collection names as a file attribute (f.attrs["catalog"]) rather than as an index_map dataset, since index_map annotates axes - Add comments to _UnresolvedBackground explaining the SCK parameter values and their re-parameterization for the sub-0.1 Jy flux regime - Update all docstrings to reflect the new catalog storage location
Contributor
Author
|
The names of the tasks have been changed - And also the name of the catalog is being saved as an attributes. |
ljgray
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add four new classes to
cora.foreground.pointsourceand corresponding commands tocora-makeskyfor generating sky maps from thefluxcatcatalog. This is needed forEigenCalibrationtoo, as Eigen calibration usesfluxcatpoint source catalog position and flux for calibration.FluxCatPointSources: likeRealPointSourcesbut driven by fluxcat, with optional flux_min/flux_max filtering at 600 MHz.SingleFluxCatSource: single named source (e.g. CYG_A) looked up from fluxcat, placed in a HEALPix map at each frequency.FluxCatCatalogMap: all sources in the loadedfluxcatcatalog, no flux filtering.CombinedFluxCatPointSources: same three-layer structure asCombinedPointSources(Gaussian unresolved + DiMatteo synthetic population + real resolved) but replacesRealPointSourceswithFluxCatPointSourcesabove 4 Jy at 600 MHz.All four classes record which
fluxcatcollections were used inindex_map/catalogin the output HDF5 file for tracking which catalog is being used.New makesky commands:
pointsource-fluxcat,singlesource-fluxcat,catalog-fluxcat,foreground-fluxcat.