fix(scripts): upgrade pointsource-fluxcat to use CombinedFluxCatPoint…#92
Merged
Merged
Conversation
…Sources Previously the pointsource-fluxcat command only simulated real fluxcat sources, unlike the pointsource command which uses a three-tier model. Switch to CombinedFluxCatPointSources so the command now follows the same structure: - S < 0.1 Jy (at 151 MHz): Gaussian approximation for unresolved background - 0.1 Jy < S < 4 Jy (at 600 MHz): synthetic DiMatteo population - S > 4 Jy (at 600 MHz): real sources from the fluxcat catalog Replace --flux-min/--flux-max with --maxflux to match the convention used by the pointsource and foreground-fluxcat commands.
ljgray
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
pointsource-fluxcatcommand only simulated real fluxcat sources, unlike the pointsource command, which uses a three-tier model. Switch toCombinedFluxCatPointSourcesso the command now follows the same structure. We have a taskcatalog-fluxcatwhich simulates only fluxcut catalog-based point sources.