Truncation weight broadcasting and get weights from a property#312
Merged
Conversation
ljgray
changed the title
ssiegelx
approved these changes
Dec 16, 2024
ssiegelx
left a comment
ssiegelx
left a comment
Contributor
There was a problem hiding this comment.
Thanks, it will be great to have this merged. I just have one question.
ljgray
force-pushed
the
ljg/truncate-from-attr
branch
from
9648d8e to
8997970
Compare
ljgray
force-pushed
the
ljg/truncate-from-attr
branch
from
8997970 to
c129829
Compare
ssiegelx
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls some useful functionality from #259.
These commits are required when to broadcast weights when compressing a
HybridVisStream, but were previously contained in a much larger PR