Static frequency mask estimation from visibility data#381
Merged
Conversation
3f35410 to
9902473
Compare
62834c6 to
c8d3091
Compare
c670310 to
e2c0267
Compare
cd84d81 to
fc60885
Compare
701a343 to
f2796ea
Compare
Contributor
Author
f2796ea to
b25f71d
Compare
Contributor
|
sorry, was hoping to take a look this pm |
Contributor
Author
No worries. It won't break anything, so it's really just a review of what's being implemented in this task, which I'd ideally like to improve on in the future anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overall goal of this PR is to implement a task to come up with a static RFI mask from visibility data directly, without having to rely on a hard-coded set of bad channels.
This produces a flagging metric by reducing over baselines using the existing
ReduceChisqcode as follows:Flagging is then done using a simple 1D MAD metric over the 1D median in time of the chisq metric. Only nighttime data is included in the median (the hook is implemented in a
ch_pipelinePR). It uses an updated version of thearPLSbaseline-fitting code, which is better able to handle the lack of hard-coded static mask.This PR does the following:
scale_invariant_rankoperation to be a bit fasterMaskBaselinestask to mask polarisation and to optionally combine the mask using anandoperationReduceBasetask with a hook for custom weightspenalized_least_squaresimplementation to support different weighting schemesThis code all works and is tested. This method does not appear to overflag, although there is absolutely room for improvement.