Skip to content

Enable lto and add macos tests#396

Merged
ljgray merged 3 commits into
mainfrom
ljg/update-compiler-check
Feb 18, 2026
Merged

Enable lto and add macos tests#396
ljgray merged 3 commits into
mainfrom
ljg/update-compiler-check

Conversation

@ljgray

@ljgray ljgray commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@ljgray ljgray requested a review from ketiltrout February 6, 2026 00:27

@ketiltrout ketiltrout left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, though I don't get why the compiler and linker args are handled differently.

Comment thread setup.py Outdated
@ljgray

ljgray commented Feb 6, 2026

Copy link
Copy Markdown
Contributor Author

I think I have to make some changes anyway to handle macos-specific stuff the popped up in the similar caput PR. We should probably be testing on macos everywhere instead of just caput...

@ljgray ljgray force-pushed the ljg/update-compiler-check branch 2 times, most recently from 5544113 to 8e1150f Compare February 6, 2026 20:36
@ljgray

ljgray commented Feb 6, 2026

Copy link
Copy Markdown
Contributor Author

This is failing because it needs cora to compile properly on macos

@ljgray ljgray force-pushed the ljg/update-compiler-check branch from 8e1150f to 1914c84 Compare February 7, 2026 00:20
@ljgray ljgray changed the title Enable lto Enable lto and add macos tests Feb 7, 2026
@ljgray ljgray force-pushed the ljg/update-compiler-check branch from 5fe63ff to 16018fd Compare February 18, 2026 18:02
@ljgray ljgray merged commit 8a53b14 into main Feb 18, 2026
6 checks passed
@ljgray ljgray deleted the ljg/update-compiler-check branch February 18, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants