Skip to content

Comments

Reorder docker command for accuracy#11210

Open
willtsai wants to merge 2 commits intomainfrom
willtsai-patch-1
Open

Reorder docker command for accuracy#11210
willtsai wants to merge 2 commits intomainfrom
willtsai-patch-1

Conversation

@willtsai
Copy link
Contributor

@willtsai willtsai commented Feb 10, 2026 •
edited
Loading

Description

This pull request makes a minor update to the documentation to correct the order of commands in an example for building and pushing Docker images.

  • Documentation: Corrected the example command in README.md to run docker-build before docker-push, ensuring images are built before being pushed.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: N/A

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

@willtsai
Reorder docker command for accuracy
6b7bba3 
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
@willtsai willtsai requested a review from a team as a code owner February 10, 2026 01:40
Copilot AI review requested due to automatic review settings February 10, 2026 01:40
@willtsai willtsai requested a review from a team as a code owner February 10, 2026 01:40
@willtsai willtsai requested a deployment to external-contributor-approval February 10, 2026 01:40 — with GitHub Actions Waiting
Copilot AI reviewed Feb 10, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the contributing documentation to ensure the example Make target order builds container images before attempting to push them to a registry.

Changes:

  • Reordered the example command to run make docker-build before make docker-push.

@willtsai
Update docs/contributing/contributing-code/contributing-code-building…
922bb96 
…/README.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
@willtsai willtsai temporarily deployed to external-contributor-approval February 10, 2026 16:41 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@brooke-hamilton brooke-hamilton brooke-hamilton approved these changes

@nicolejms nicolejms nicolejms approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@willtsai @brooke-hamilton @nicolejms