Skip to content

Comments

Update CODEOWNERS to include new directories#633

Merged
Ying1123 merged 1 commit intomainfrom
Ying1123-patch-1
Feb 24, 2026
Merged

Update CODEOWNERS to include new directories#633
Ying1123 merged 1 commit intomainfrom
Ying1123-patch-1

Conversation

@Ying1123
Copy link
Member

Added CODEOWNERS for megatron_utils and sglang_utils directories.

Added CODEOWNERS for megatron_utils and sglang_utils directories.
@Ying1123 Ying1123 requested a review from fzyzcjy as a code owner February 24, 2026 06:09
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Ying1123, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request ensures that new directories within the 'miles/backends' path have designated code owners. This is crucial for maintaining code quality, accountability, and streamlining the review process for changes made to these specific parts of the codebase.

Highlights

Changelog
  • .github/CODEOWNERS
    • Added entries for '/miles/backends/megatron_utils/' and '/miles/backends/sglang_utils/' with specific owner assignments.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .github/CODEOWNERS file to assign owners to the new megatron_utils and sglang_utils directories. No security vulnerabilities were found. A suggestion has been made to improve the long-term maintainability of the CODEOWNERS file by utilizing GitHub teams, which would help reduce duplication and simplify future updates.

Comment on lines +5 to +6
/miles/backends/megatron_utils/ @fzyzcjy @yueming-yuan @maocheng23 @yushengsu-thu
/miles/backends/sglang_utils/ @fzyzcjy @yueming-yuan @maocheng23 @yushengsu-thu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this is correct, repeating the list of owners @fzyzcjy @yueming-yuan @maocheng23 can become a maintenance burden if more directories are added or ownership changes.

For better long-term maintainability, consider using a GitHub team for this common set of owners. For example, you could create a team (e.g., @<org>/miles-backend-owners) for @fzyzcjy @yueming-yuan @maocheng23.

Then, these lines and others in the file could be simplified:

# In this PR
/miles/backends/megatron_utils/ @<org>/miles-backend-owners @yushengsu-thu
/miles/backends/sglang_utils/ @<org>/miles-backend-owners @yushengsu-thu

# Elsewhere in the file
/miles/backends/ @<org>/miles-backend-owners

This makes it easier to manage ownership changes in the future, as you'd only need to update the team membership in one place.

@Ying1123 Ying1123 merged commit d5ca90d into main Feb 24, 2026
5 checks passed
@Ying1123 Ying1123 deleted the Ying1123-patch-1 branch February 24, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant