improve(skills/orchestrator): Nemotron COMPLEX review cycle (hour 13 UTC)#172
Open
raelli wants to merge 1 commit into
Open
improve(skills/orchestrator): Nemotron COMPLEX review cycle (hour 13 UTC)#172raelli wants to merge 1 commit into
raelli wants to merge 1 commit into
Conversation
…e LLM dispatch Nemotron COMPLEX review cycle (hour 13 UTC)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated self-improvement pass on
src/skills/orchestrator/index.js. Reviewed by Nemotron COMPLEX — tests pass.Change
Coerce a non-string
queryvalue to a string viasafeStringifybefore pushing it onto the LLM messages array. The OpenAI/LiteLLM API requirescontentto be a string; passing a raw object or number would silently produce a malformed request. The defaultquery = ""already makes this a no-op for the common case; the coercion only fires when a caller supplies a non-string value.Why only this change
The Nemotron draft also suggested:
callLLMerrors in the orchestrator — rejected becausedispatchSSEalready centralises error handling and emits a spec-compliant{ error: { code, message } }frame on throw; catching internally would swallow the real message and emit a fake-success frame instead.skill.handleerrors — same reasoning as above.Object.hasOwnforhasOwnProperty.call— Node 18+ is already required (husky 9 constraint), so this is churn with no correctness gain.rawArgs— the OpenAI tool-call contract always delivers a JSON string here; adding untested handling for a hypothetical violates the "no new features" constraint.The review verdict was
null(router timed out at 90 s), so only the unambiguous, well-scoped suggestion was applied.750/750 tests pass.
Generated by Claude Code