Repository navigation
fix: exclude UnmarshalJSONFrom by default - #52
Merged
Merged
Conversation
encoding/json/v2 (stable in Go 1.27) adds the UnmarshalerFrom interface. Like UnmarshalJSON, UnmarshalJSONFrom must use a pointer receiver, so value-receiver types that adopt it were reported as mixed receivers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
encoding/json/v2is stable in Go 1.27 (blog) and adds theUnmarshalerFrominterface:Like
UnmarshalJSON, it must use a pointer receiver. A value-receiver type that adopts it is reported today, while the same type withUnmarshalJSONis not:What
*.UnmarshalJSONFromto the built-in exclusions.JSONV2type to thebuiltinmethodsanddisablebuiltintestdata. It uses local stand-ins for thejsontexttypes, sogo.modstays atgo 1.26.0.MarshalJSONinstead ofUnmarshalJSON.MarshalJSONTois not excluded, the same asMarshalJSON.Test
go test -race .passes, andgolangci-lint runreports 0 issues.analyzer.gochange reverted,builtinmethodsfails with an unexpected diagnostic onJSONV2.