Inline non-fast-forward check and add review guidelines - #30
Merged
Conversation
- Add `Commit.isNonFastForwardError` static method replacing the standalone `src/cli/commit-errors.ts` module. - Update the push retry path in `src/cli/commit.ts` to call `Commit.isNonFastForwardError` and drop the removed import. - Delete the single-use `src/cli/commit-errors.ts` module. - Update `test/cli/commit-errors.test.ts` to import `Commit` and assert against the static method.
- Add `AGENTS.md` defining P0/P1 blocking criteria for reviews. - Document non-blocking exclusions and the required fields for every finding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds
AGENTS.mdreview guidelines to keep automated/code reviews high-signal (only P0/P1 blocking findings), and consolidates the non-fast-forward error check into theCommitclass to remove a single-use module.What's New
Review guidelines
AGENTS.mddefining P0/P1 blocking criteria and explicit non-blocking exclusions for reviews.Error-check consolidation
isNonFastForwardErrorinto aCommit.isNonFastForwardErrorstatic method.src/cli/commit-errors.tsmodule.src/cli/commit.tsand the test imports accordingly.Testing & Feedback
npm test(Vitest) and confirmcommit-errors.test.tspasses againstCommit.isNonFastForwardError.