Fix OpenAI reasoning effort capabilities - #31
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95229a70b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Accept single, double, and backtick delimiters in message-only unsupported-effort responses. - Cover the message-only backtick fallback with OpenAI stream tests.
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Motivation
■ Failed to create OpenAI response: 400 Unsupported value:
minimalis not supported with thegpt-5.6-solmodel. Supported values are:none,low,medium,high, andxhigh.What's New
Model-Aware Effort Selection
commit effort; API-key OpenAI and other providers retain their offline behavior.Resilient OpenAI Requests
reasoning, allowing the provider default.provider default.OpenAI Effort Selection Flow
graph TD A[OpenAI OAuth model catalog] --> B[Model capabilities] B --> C[Effort picker] C --> D[Responses request] D --> E{Unsupported effort 400?} E -->|No| F[Use selected effort] E -->|Yes, once| G[Retry without reasoning] G --> H[Provider default effort] style B fill:#808080,stroke:#333,stroke-width:2px style G fill:#808080,stroke:#333,stroke-width:2pxTesting & Feedback
minimalconfig decoding, OAuth refresh behavior, narrow fallback, and effective-effort metadata.pnpm test,pnpm typecheck,pnpm lint, andpnpm build.If you find any bugs or have recommendations for improvements, please open an issue and assign it to me.