Skip to content

make keras-vis compatible with TF2.1#220

Open
macfly1202 wants to merge 1 commit intoraghakot:masterfrom
macfly1202:macfly1202-patch-tf2.1-compatible
Open

make keras-vis compatible with TF2.1#220
macfly1202 wants to merge 1 commit intoraghakot:masterfrom
macfly1202:macfly1202-patch-tf2.1-compatible

Conversation

@macfly1202
Copy link
Copy Markdown

I make minor change to use TF1 behavior with Keras-Vis.
Some warning still exists but no blocking

I make minor change to use TF1 behavior with Keras-Vis.
@keisen
Copy link
Copy Markdown
Collaborator

keisen commented Apr 21, 2020

Thank you for this PR!

Before we merge this PR, could you improve something that is to keep comatibility with Keras that is original, not tf.keras.
As following page, Keras support TF1.* and TF2.0., so we believe that keras-vis should also support TF1. .

https://github.com/keras-team/keras#multi-backend-keras-and-tfkeras

@makquel
Copy link
Copy Markdown

makquel commented Dec 22, 2020

This minor change helps to deal compatibility error from the most recent keras wrapper API.

AttributeError: module 'tensorflow' has no attribute 'get_default_graph'

However, other errors appear with TensorFlow back end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants