Skip to content

About medicare component created#43

Open
Mujahidul-Islam11 wants to merge 5 commits intomasterfrom
feature/about_dinar
Open

About medicare component created#43
Mujahidul-Islam11 wants to merge 5 commits intomasterfrom
feature/about_dinar

Conversation

@Mujahidul-Islam11
Copy link
Copy Markdown
Collaborator

No description provided.

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medicare ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 6:05am

Comment thread package.json
Comment on lines +9 to +10
"lint": "next lint",
"lint:fix": "prettier --write ."
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need to use others packages when you can fix it with command?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried but I donno why the commands that you gave me aren't working

Comment thread src/app/about/page.js
Comment on lines +5 to 7
<div>
<AboutUs />
</div>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use arrow and don't keep unnecessary code on codebase please do like this:
const AboutUss = () => <AboutUs> export default AboutUss

Comment thread src/app/about/page.js
@@ -2,7 +2,7 @@ import AboutUs from "@/components/AboutUs/AboutUs";

const AboutUss = () => {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the page name give a meaningful name of the page, Like AboutUsPage

import AppButton from "@/UI/AppButton";
import ComponentHeader from "@/UI/ComponentHeader";
import Image from "next/image";
import { useState } from "react";
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import the useState hooks at top.

Comment on lines +20 to +25
<Image
width={400}
height={500}
src="/assets/about_mdc.png"
alt="Doctor"
className="rounded-lg w-full"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add lazy loading and quality in image component for better optimization.

Comment on lines +31 to +43
<svg
xmlns="http://www.w3.org/2000/svg"
fill="white"
viewBox="0 0 24 24"
strokeWidth="1.5"
stroke="currentColor"
className="w-10 h-10"
>
<path
strokeLinecap="round"
strokeLinejoin="round"
d="M6.75 12l7.5-4.5v9l-7.5-4.5z"
/>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the svg file on customSvg folder on the code base and import it from there.


{/* Right Section*/}
<div className="w-full md:w-1/2 space-y-5">
<ComponentHeader title={"About Medicare"} titleClasses="text-start text-20" />
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use it like this way: <ComponentHeader title="About Medicare" titleClasses="text-start text-20" />

originated in the 16th century. Lorem Ipsum is composed in a pseudo-Latin language.
</p>
<AppButton
text={"Read More"}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont use curly braches use it like this way: text="Read More"

Comment on lines +80 to +89
<svg
xmlns="http://www.w3.org/2000/svg"
fill="none"
viewBox="0 0 24 24"
strokeWidth="1.5"
stroke="currentColor"
className="w-6 h-6"
>
<path strokeLinecap="round" strokeLinejoin="round" d="M6 18L18 6M6 6l12 12" />
</svg>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the svg file on customSvg folder on the code base and import it from there.

Comment on lines +8 to +9
title={"Our Medical Services"}
desc={"Prompt and reliable care for emergencies, treatments, and consultations."}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont use curly braches when passing something through props

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants