Add support for CreateScan and GetScanTasks in RESTCatalog#1
Open
Add support for CreateScan and GetScanTasks in RESTCatalog#1
Conversation
jackye1995
reviewed
Dec 5, 2023
| import org.apache.iceberg.util.ArrayUtil; | ||
|
|
||
| abstract class BaseContentScanTask<ThisT extends ContentScanTask<F>, F extends ContentFile<F>> | ||
| public abstract class BaseContentScanTask< |
There was a problem hiding this comment.
is it necessary to make this public? can we avoid changing this?
jackye1995
reviewed
Dec 5, 2023
| return deletesSizeBytes; | ||
| } | ||
|
|
||
| @VisibleForTesting |
jackye1995
reviewed
Dec 5, 2023
jackye1995
reviewed
Dec 5, 2023
| String filterString = ExpressionParser.toJson(filter()); | ||
|
|
||
| CreateScanRequest request = | ||
| CreateScanRequest.builder().withselect(columnNames()).withfilter(filterString).build(); |
There was a problem hiding this comment.
the capitalization seems wrong, should be withSelect, withFilter, etc.
jackye1995
reviewed
Dec 5, 2023
| return select; | ||
| } | ||
|
|
||
| public String filter() { |
There was a problem hiding this comment.
I think we should set Expression, but not String. The request parser should parse it to string.
jackye1995
reviewed
Dec 5, 2023
| return filter; | ||
| } | ||
|
|
||
| public Map<String, String> options() { |
There was a problem hiding this comment.
can we remove this? we don't need this for OSS
jackye1995
reviewed
Dec 5, 2023
| return this; | ||
| } | ||
|
|
||
| public Builder withshard(String newshard) { |
jackye1995
reviewed
Dec 5, 2023
rahil-c
force-pushed
the
rchertar/main
branch
from
d86bba3 to
0a21d0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.