Adding ability to block only specific URLs#9
Open
mukilk7 wants to merge 1 commit intorahulgi:masterfrom
Open
Conversation
Owner
|
Hi @mukilk7! Sorry for taking so long to see this PR, I don't check this repository very often, and I apparently didn't set it to send me email notifications on activity. I really appreciate you contributing to this tool! I don't have time to review this PR fully right now, but now that I've seen it I'll try to get comments in ASAP. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Rahul,
I extended your extension to block only specific URLs instead of the entire domain. For example, when I block - http://www.reddit.com/r/videos, and then visit - http://www.reddit.com/r/nfl - I should be allowed to visit the page. I've added a new button to the popup page for blocking just the current URL. I've updated the description to describe how the two buttons behave for blacklisted and non-blacklisted pages.
Cheers,
Mukil