test: CLI integration tests + clippy pedantic#8
Merged
rahulrajaram merged 4 commits intoMar 26, 2026
Conversation
Add comprehensive integration tests for 18 previously uncovered commands: stats, check-links, backlinks, orphans, canonicality, canonical-orphans, similar, dupes, dupes-sections, diff, export-graph, assemble, check, suggest-consolidation, eval, build (JSON), policy, and stale. Enable #![warn(clippy::pedantic)] at crate level with targeted allows for intentional patterns. Fix case-sensitive extension comparisons, let-else patterns, clone efficiency, format push strings, and inline format args across all source and test files.
Commit squash-scope reviewRange: Heuristic candidates
Suggested next actionI found 2 candidate adjacent commit pairs to review for squashing.
These are heuristics only. Use your judgment before collapsing history. SQUASH_SCOPE_NEEDS_REWRITE=1 |
Add `renamed_and_removed_lints` allow to suppress errors when `match_on_vec_items` is renamed in CI's newer clippy (Rust 1.94+). Also allow `implicit_clone` which is newly enforced in that version.
The allow must precede the block containing match_on_vec_items so it takes effect before CI's `-D warnings` can reject the removed lint.
Lower similarity threshold to 0.1 and keep fixture documents nearly identical so MinHash similarity stays high regardless of platform hash seeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/cli_integration.rscovering 18previously untested CLI commands (stats, check-links, backlinks,
orphans, canonicality, canonical-orphans, similar, dupes,
dupes-sections, diff, export-graph, assemble, check,
suggest-consolidation, eval, build JSON, policy, stale)
#![warn(clippy::pedantic)]at crate level with targetedallows for intentional patterns (casts, too_many_lines, etc.)
efficiency, format push strings, and inline format args
Test plan
cargo clippy -- -D warningscleancargo fmt --checkclean