Skip to content

Added low brightness mode, added speed mode, more documentation, added fixes from KarFreitag - #5

Open
cRoCx wants to merge 6 commits into
raidlman:masterfrom
cRoCx:lowbrightness_and_speedmode
Open

cRoCx wants to merge 6 commits into
raidlman:masterfrom
cRoCx:lowbrightness_and_speedmode

Conversation

@cRoCx

@cRoCx cRoCx commented Feb 21, 2022

Copy link
Copy Markdown

Since I've got it working a while ago I would like to contribute a few things.

  • I've added a low brightness mode which is good in low lit environments in the evening at home.
  • I've added a high speed mode, which just increases the base game speed from 0.2 to 0.6. All other speed calculations remain unaffected.
  • Both modes can be enabled by holding down either player button just before the game starts. Both modes can be enabled at the same time. No additional buttons needed.
  • I've changed the behaviour of the standby animations which start after 30s of inactivity. They no longer change every 5s, but in much slower intervals. This is less attention seeking in high traffic environments, thus maybe worse there, but more cozy at home or at a chillout evening with friends.
  • I've merged all other features and bugfixes by @KarFreitag, except his PlatformIO refactoring.
  • Unfortunately I haven't tested, how the "Start" button affects anything. I don't use the start button. I use only the two player buttons and reset the game by powering off and on the Arduino.
  • I've added more documentation from my previously opened issues and a general game description.

Markus Wirth added 6 commits March 23, 2021 13:54
…ct 2020) to get a working copy based off 729da88, but with all the fixes and improvements made later. This master branch in raidlman's repo appears to be broken: Only reset button, but none of the player buttons are working. See https://github.com/raidlman/1d-pong/blob/7a03ea0de621e74a311400ab0a429472601f9a95/Pong.cpp#L28 for comparison. The restart button is the only one being defined there.
… after bootup without pressing the reset button.
…activity for a quieter visual perception and attention by the LED's.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant