Make cryptography browser/mobile ready - #12
Merged
Merged
Conversation
mattgle
marked this pull request as ready for review
June 23, 2026 21:11
Collaborator
|
Had a quick review and it seems to be OK. Would be better with noble/curves, but that's for later. |
bhflm
requested changes
Jun 24, 2026
mattgle
force-pushed
the
feat/aes-browser-mobile
branch
from
June 24, 2026 17:00
58c5818 to
412c448
Compare
Contributor
Author
Yes we will need to make changes to wallet-node after this PR gets merged. Here's the PR for those changes railgun-reloaded/wallet-node#26 |
bhflm
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Removes the two hard browser/mobile blockers so the package runs in browsers and React Native with no Node polyfills (no
node:crypto, noBuffer).node:crypto→@noble/ciphersposeidon-litebuildEddsa→@iden3/js-crypto@noble/hashesbumped to v2;circomlibjsremoved entirelyWire formats and byte representations are unchanged and verified byte-identical to the previous implementation: AES ciphertext still decrypts, and Poseidon/EdDSA match the canonical circomlibjs reference vectors, so existing wallet keys and signatures continue to verify.
Poseidon and EdDSA are now synchronous, so the async init API (
initPoseidon,initializeEddsa,initCircomlib,poseidonBuild) is removed.