Conversation
Prover was the only @railgun-reloaded package passing --coverage to brittle, which caused every `npm test` run to emit a `coverage/` directory (and the dir wasn't gitignored, so it polluted `git status`). No other workspace package generates coverage reports today, and there is no published consumer of the prover-only report. Removing the flag brings the test script in line with bytes / storage / wallet-node / balance-scanner. If a future need for coverage emerges, it should be applied uniformly across the workspace (probably as a separate `test:coverage` script across packages) rather than in one outlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prover was the only
@railgun-reloaded/*package passing--coverageto brittle, so everynpm testrun emitted acoverage/directory (also not gitignored, so it leaked intogit status).No other workspace package generates coverage reports today, and no published consumer reads the prover-only output. Aligning the test script with bytes / storage / wallet-node / balance-scanner.
If coverage becomes a workspace-wide concern later, it should land uniformly — probably as a separate
test:coveragescript across packages — rather than in one outlier.