fix: resolve wallet id conflicts in SQL - #28
Merged
Merged
Conversation
mattgle
marked this pull request as ready for review
August 6, 2026 13:29
mattgle
force-pushed
the
fix/wallet-create-conflict-aware
branch
from
August 6, 2026 13:44
ea1f627 to
0add669
Compare
bhflm
approved these changes
Aug 6, 2026
mattgle
force-pushed
the
fix/wallet-create-conflict-aware
branch
from
August 6, 2026 14:22
0add669 to
7d42406
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createWalletwas the only insert in the package that let a constraint violation escape as an exception — every other insert resolves conflicts in SQL. It now does the same and reports whether a row was inserted.This lets a caller tell a new wallet from an existing one without recognising a driver's constraint-violation error, which was never portable anyway: the browser adapter forwards only a message string for SQL statement errors, so the driver's error code never reaches the caller.
Breaking:
createWalletreturnsbooleaninstead of the id the caller already supplied.Coverage lives in the shared contract suite, so it is asserted against both the Node and browser adapters. A conflict on any other constraint still raises, so
falsemeans the id was taken and nothing else.